ddl: skip write binlog when ddl type is update tiflash replica status #16049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs520 <[email protected]>
IANTHEREAL
reviewed
Apr 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #16049 +/- ##
===========================================
Coverage 80.4843% 80.4843%
===========================================
Files 506 506
Lines 135486 135486
===========================================
Hits 109045 109045
Misses 17946 17946
Partials 8495 8495 |
zimulala
added
the
status/can-merge
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 7, 2020
…pingcap#16049) Signed-off-by: crazycs520 <[email protected]>
|
cherry pick to release-3.1 in PR #16111 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 7, 2020
…pingcap#16049) Signed-off-by: crazycs520 <[email protected]>
|
cherry pick to release-4.0 in PR #16112 |
sre-bot
added a commit
that referenced
this pull request
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazycs520 [email protected]
What problem does this PR solve?
As title said.
Related PR: pingcap/tidb-binlog#941
What is changed and how it works?
Update TiFlash replica is a TiDB internal DDL, It's used to update the table's TiFlash replica available status, and It should not write the binlog.
Related changes
Check List
Tests
Side effects
Release note